feat: remove DOMParser to prevent memory leak

DIYgod · Feb 23, 2024 · 653f0db · 653f0db
1 parent 6ab939f
commit 653f0db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/lib/rsshub.ts b/src/lib/rsshub.ts
@@ -4,13 +4,18 @@ import { parse } from "tldts"
 import { parseRules } from "./rules"
 import type { RSSData, Rule } from "./types"
 
+const parseHtml = (html) => {
+  const template = document.createElement('template');
+  template.innerHTML = html;
+  return template.content; 
+}
+
 function ruleHandler(rule: Rule, params, url, html, success, fail) {
   const run = () => {
     let resultWithParams
     if (typeof rule.target === "function") {
       try {
-        const parser = new DOMParser()
-        const document = parser.parseFromString(html, "text/html")
+        const document = parseHtml(html)
         resultWithParams = rule.target(params, url, document)
       } catch (error) {
         resultWithParams = ""

diff --git a/src/lib/types.ts b/src/lib/types.ts
@@ -2,7 +2,7 @@ export type Rule = {
   title: string
   docs: string
   source: string[]
-  target: string | ((params: any, url: string, document: Document) => string)
+  target: string | ((params: any, url: string, document: DocumentFragment) => string)
 }
 
 export type Rules = {