Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dotnet 6 SDK #40

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Install dotnet 6 SDK #40

wants to merge 21 commits into from

Conversation

timbussmann
Copy link

@timbussmann timbussmann commented May 22, 2022

Starting with .NET Core, there should be no need to use mono. This PR adds the .NET 6 SDK using the APT package installation documentation. Installing the .NET SDK seems to be the first step before looking into adding a executor?

Not exactly sure how reliably this works with debian:sid since the guidance only documents stable releases but it seems to work on my machine (TM). I had to replace the wget https://packages.microsoft.com/config/debian/10/packages-microsoft-prod.deb -O packages-microsoft-prod.deb from the documentation to using curl since wget didn't seem to be available somehow?

An alternative would be to use the installation script which looks simpler (curl -sSL "https://dot.net/v1/dotnet-install.sh" | bash /dev/stdin) and might require less maintenance effort but it won't add the dotnet executable path and that would have to be done separately.

@timbussmann
Copy link
Author

@Xyene @quantum5 any interest/thoughts on this?

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, been very busy with work, thanks for sending this in.

I'm not sure we want to replace the Mono C# executor with this, but we should be able to add a separate C# executor.

tier3/Dockerfile Outdated Show resolved Hide resolved
tier3/Dockerfile Outdated Show resolved Hide resolved
@timbussmann
Copy link
Author

Sorry, been very busy with work, thanks for sending this in.

no worries, I just wasn't sure you noticed the PR.

I'm not sure we want to replace the Mono C# executor with this, but we should be able to add a separate C# executor.

👍

Thanks for the review, will update the PR a few spare minutes.

@timbussmann
Copy link
Author

haven't had the chance yet to verify whether dotnet is correctly available on a container instance.

@timbussmann
Copy link
Author

tweaked it a bit further, have another look @Xyene

@Xyene
Copy link
Member

Xyene commented Aug 31, 2022

Thanks @timbussmann. I'll hold off on merging until a judge-side PR is ready, but this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants