2주차 Test Code 작성 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
unanchoi
commented
Mar 1, 2024
unanchoi
commented
- 스터디 진행하면서 작성해서, PR 상에는 10개보다 적을 수 있습니다 ~~
sung-silver
approved these changes
Mar 5, 2024
| // if (!name.matches("ㅎ가-힣")) { | ||
| // throw new MemberException("한글만 가능합니다."); | ||
| // } | ||
| if (!name.matches("^[가-힣]*$")) { |
| @@ -74,6 +75,6 @@ private void validateNickname(final String nickname) { | |||
| } | |||
|
|
|||
| public void updateSOPT(SOPT sopt) { | |||
| this.sopt = sopt; | |||
| this.sopt.updateSopt(sopt); | |||
There was a problem hiding this comment.
하단에 updateSopt 함수를 만들고 여기서 한번 더 실행하는 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.