More validation and hints #64
Conversation
| "definitions": { | ||
| "invalid-command-substitution": { | ||
| "type": "string", | ||
| "pattern": "\\$\\(\\s*\\)" |
There was a problem hiding this comment.
What is this preventing? $()?
Is it important to prevent this specifically, and not other invalid strings?
There was a problem hiding this comment.
What is this preventing? $()?
It prevents empty command substitutions like echo $().
Is it important to prevent this specifically, and not other invalid strings?
Can you provide examples what other strings it would be nice to prevent from being entered?
There was a problem hiding this comment.
Even echo anything is not expected to be there.
My point is, what is the point of limiting? This should be a simple list with all sorts of syntaxes available. Limiting can potentially prevent valid use cases that we haven't thought about.
I think that the original definition - list of strings - was sufficient to express what is expected.
There was a problem hiding this comment.
I thought an arbitrary shell command could be entered. I guess it's the root of my mistake. Should I close this PR?
--