Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix/postfix buttons disappearing when colReorder is also used #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demetris-manikas
Copy link

Hi.

I use both the colVis and colReorder plugins and I noticed that if a column has been moved then
all prefix/postfix buttons that I have defined along with the colvis button vanish.

Here is the definition I use

var button = {
        extend: 'colvis',
        text: 'Reset',
        columns: ':not(.colvis-ignore)',
        postfixButtons: [
            {
               extend: 'colvisRestore',
            }
        ]
    }

This PR addresses this issue.
Please let me know whether I should setup a showcase for this.
Thanks a lot for your time.

@AllanJard
Copy link
Contributor

Many thanks for this! I'll review it properly before the next Buttons release. Are you happy for this to be included under the MIT license?

@demetris-manikas
Copy link
Author

Yes of course I am.

@demetris-manikas
Copy link
Author

demetris-manikas commented Feb 2, 2022

I have also created an almost identical to colVis extension (renames mostly) for manipulating the searchable property.
Would you be interested in that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants