addition of sets now removes duplicates

DavZim · Oct 17, 2023 · dd0b6d8 · dd0b6d8
1 parent b45d3ed
commit dd0b6d8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/R/ruleset_construction.R b/R/ruleset_construction.R
@@ -21,6 +21,8 @@ datavarifyr_plus <- function(a, b) {
     out <- c(a, b)
   }
 
+  out <- out[!duplicated(out)]
+
   for (i in seq_along(out)) {
     out[[i]]["index"] <- i
   }

diff --git a/tests/testthat/test-ruleset_construction.R b/tests/testthat/test-ruleset_construction.R
@@ -41,6 +41,20 @@ test_that("rulesets can be added to rules", {
       )
 })
 
+test_that("duplicates are removed when adding rules and rulesets", {
+      rule_1 <- rule(mpg > 10)
+      rule_2 <- rule(hp > 10)
+      expect_equal(
+        length(ruleset(rule_1, rule_2) + ruleset(rule_1, rule_2)),
+        2
+      )
+
+      expect_equal(
+        length(rule_1 + rule_2 + ruleset(rule_1, rule_2) + ruleset(rule_1, rule_2)),
+        2
+      )
+})
+
 test_that("bind_rules works", {
       rule_1 <- rule(mpg > 10)
       rule_2 <- rule(hp > 10)