Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLSA gentoo vulnid #9813

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Mar 22, 2024

Add GLSA gentoo vulnid and logic to resolve it.

Copy link

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 1 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@manuel-sommer manuel-sommer deleted the remove_psycopg2 branch March 27, 2024 08:22
@manuel-sommer manuel-sommer restored the remove_psycopg2 branch November 16, 2024 17:52
@manuel-sommer manuel-sommer reopened this Nov 16, 2024
Copy link

dryrunsecurity bot commented Nov 16, 2024

DryRun Security Summary

The pull request focuses on improving the handling of vulnerability IDs and their corresponding URLs within the DefectDojo application, including the introduction of support for a new vulnerability ID prefix "GLSA" and enhancements to the URL generation process to handle different vulnerability ID formats and support more complex URL structures.

Expand for full summary

Summary:

The code changes in this pull request focus on improving the handling of vulnerability IDs and their corresponding URLs within the DefectDojo application. The key changes include:

  1. Introducing support for a new vulnerability ID prefix "GLSA" (Gentoo Linux Security Advisory), which allows the application to generate URLs for these types of vulnerabilities.
  2. Updating the URL generation logic to handle different vulnerability ID formats (e.g., "AVD", "KHV", "C-") by converting them to lowercase before generating the URL.
  3. Enhancing the URL generation process to support vulnerability IDs with "&&" in the VULNERABILITY_URLS setting, allowing for more complex URL structures.
  4. Adding a new vulnerability URL mapping for the "GLSA" vulnerability identifier in the application settings.

From an application security perspective, these changes do not introduce any obvious security concerns, as they primarily focus on improving the flexibility and usability of the vulnerability management functionality within DefectDojo. As long as the VULNERABILITY_URLS settings are properly configured and validated, these changes should not introduce any security vulnerabilities.

Files Changed:

  1. dojo/templatetags/display_tags.py: This file contains the vulnerability_url function, which has been updated to handle the new "GLSA" vulnerability ID prefix and improve the handling of other ID formats.
  2. dojo/settings/settings.dist.py: This file has been updated to include a new vulnerability URL mapping for the "GLSA" vulnerability identifier, allowing DefectDojo to generate links to the corresponding Gentoo security advisory pages.
  3. dojo/settings/.settings.dist.py.sha256sum: This file contains a checksum for verifying the integrity of the dojo/settings/.settings.dist.py file. The checksum has been updated to reflect the changes made in the settings.dist.py file.

Code Analysis

We ran 9 analyzers against 3 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 2 findings

Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

@manuel-sommer manuel-sommer marked this pull request as draft November 16, 2024 17:54
@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Nov 16, 2024
@manuel-sommer manuel-sommer changed the title Remove psycopg2-binary Add GLSA gentoo vulnid Nov 16, 2024
@github-actions github-actions bot added the ui label Nov 16, 2024
@manuel-sommer manuel-sommer marked this pull request as ready for review November 16, 2024 20:50
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants