Improve access transformers #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden by the `--info` flag by default, is helpful for determining where ATs are (or aren't) coming from
Will now crash whenever lines are missed to give a clear feedback of what it happening No more guessing why an AT doesn't apply
Allows using 1.13.1 mappings with 1.13.2
|
Also adds back the bulk of |
Remember to test after refactoring
Missed the top of the method out whilst copying over
|
Having managed to make a clean 1.13.2 setup, it definitely works as intended now. |
No more getting confused between identical maven groups
This should of been removed years ago, but nobody ever did it. Forge version must be specified in full string format.
Fixes LaunchWrapper being missing from the classpath when run from Gradle Shouldn't break anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now they have a tendency to be very quiet about not working, which can be a problem when you're trying to tell if
public method bgl a (Laxg;Lej;Lep;)Lbmf;is right or not.By crashing if there are unprocessed lines, there is obvious evidence of whether the line is right or not. Either it doesn't and it must have applied or it did and wouldn't have otherwise been used. Unmasking these issues makes using the Notch names just a little easier, especially as it saves waiting for Minecraft to deofuscate and recompile to see if your AT worked.