Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テスト用configファイルがある時は切り替える EC-CUBE#1013 #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clicktx
Copy link
Contributor

@clicktx clicktx commented Sep 29, 2024

fixed #1013

ただ、heroku用のコード(下記部分)に影響があるかもしれないのですが未検証です。

// heroku用
} else if (getenv('DATABASE_URL')) {
ini_set( 'display_errors', 1 );
copy(realpath(dirname(__FILE__)) . '/../../tests/config.php', CONFIG_REALFILE);
require_once CONFIG_REALFILE;
} else if (!GC_Utils_Ex::isInstallFunction()){

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (74eaa0a) to head (b95b601).

Files with missing lines Patch % Lines
data/class/SC_Initial.php 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   56.29%   56.27%   -0.03%     
==========================================
  Files          75       75              
  Lines        8917     8921       +4     
==========================================
  Hits         5020     5020              
- Misses       3897     3901       +4     
Flag Coverage Δ
tests 56.27% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor

@clicktx ありがとうございます!
Heroku は有料化以降、ほとんど使われなくなり、テストもされてないので無視しても良いかなと思っています。
data/config/config4test.php.example のデフォルト値は環境変数とかにしておくと、もっと利便性上がりそうですがいかがでしょうか?

@clicktx
Copy link
Contributor Author

clicktx commented Sep 30, 2024

@nanasess なるほど、個人的には環境変数で設定していませんが便利そうですね。

<?php

// テスト実行時に使用する設定ファイル
// config4test.phpにリネームして配置するとテスト実行時に使用されます。

define('ECCUBE_INSTALL', 'ON');
define('HTTP_URL', getenv('HTTP_URL') ?: 'http://example.com/eccube/html/');
define('HTTPS_URL', getenv('HTTPS_URL') ?: 'https://example.com/eccube/html/');
define('ROOT_URLPATH', getenv('ROOT_URLPATH') ?: '/eccube/html/path/');
define('DOMAIN_NAME', getenv('DOMAIN_NAME') ?: '');
define('DB_TYPE', getenv('DB_TYPE') ?: 'pgsql_or_mysql');
define('DB_USER', getenv('DB_USER') ?: 'your_db_user');
define('DB_PASSWORD', getenv('DB_PASSWORD') ?: 'your_password');
define('DB_SERVER', getenv('DB_SERVER') ?: 'db_server');
define('DB_NAME', getenv('DB_NAME') ?: 'eccube_db_name');
define('DB_PORT', getenv('DB_PORT') ?: '');
define('ADMIN_DIR', getenv('ADMIN_DIR') ?: 'admin/');
define('ADMIN_FORCE_SSL', getenv('ADMIN_FORCE_SSL') ?: TRUE);
define('ADMIN_ALLOW_HOSTS', getenv('ADMIN_ALLOW_HOSTS') ?: 'a:0:{}');
define('AUTH_MAGIC', getenv('AUTH_MAGIC') ?: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx');
define('PASSWORD_HASH_ALGOS', getenv('PASSWORD_HASH_ALGOS') ?: 'sha256');
define('MAIL_BACKEND', getenv('MAIL_BACKEND') ?: 'smtp');
define('SMTP_HOST', getenv('SMTP_HOST') ?: 'mailcatcher');
define('SMTP_PORT', getenv('SMTP_PORT') ?: '25');
define('SMTP_USER', getenv('SMTP_USER') ?: '');
define('SMTP_PASSWORD', getenv('SMTP_PASSWORD') ?: '');

define('TEST_MAILCATCHER_URL', getenv('TEST_MAILCATCHER_URL') ?: 'http://127.0.0.1:1080');

みたいな感じでしょうか?
これだと、docker-compose.ymlのenvironmentに設定されている影響で設定ファイルに書いてもそちらが優先されてしまうでしょうか?

普通に環境を作って、通常のconfigファイルの内容をコピペして必要なところだけ直して使っている感じなので、良い方法が思いつきません(汗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

テストで使用されるconfigファイルを切り替えたい
2 participants