Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP-CS-Fixer の導入 #996

Merged
merged 11 commits into from
Oct 6, 2024
Merged

PHP-CS-Fixer の導入 #996

merged 11 commits into from
Oct 6, 2024

Commits on Sep 5, 2024

  1. PHP-CS-Fixer の導入

    @nanasess
    nanasess committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bfc9f5d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge remote-tracking branch 'upstream/master' into php-cs-fixer

    @nanasess
    nanasess committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4381058 View commit details
    Browse the repository at this point in the history

  2. 副作用のありそうなルールを除外 

    - string_length_to_empty
- ternary_to_elvis_operator
    @nanasess
    nanasess committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9326ac0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. php-cs-fixer を適用すると削除されるため1行に修正

    @nanasess
    nanasess committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e96e7fe View commit details
    Browse the repository at this point in the history

  2. php-cs-fixer のルールを整理 

    - コメント追記
- `single_quote => true` に変更(4系にあわせる)
- `concat_space => ['spacing' => 'none']` に変更(4系にあわせる)
- `array_syntax => true` に変更(4系にあわせる)
- `phpdoc_scalar => true` に変更(phpdoc の int や bool を統一したい)
- `data/smarty_extends` 及び `tests` にも適用
    @nanasess
    nanasess committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    94d493c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into php-cs-fixer

    @nanasess
    nanasess committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a9a7e00 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Apply PHP_CS_FIXER_IGNORE_ENV=1 data/vendor/bin/php-cs-fixer fix --al… 

    …low-risky=yes
    @nanasess
    nanasess committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    da8ad32 View commit details
    Browse the repository at this point in the history

  2. trailing_comma_in_multiline => false は削除 

    `, ]` となる箇所は別途修正する
see EC-CUBE#996 (comment)
    @nanasess
    nanasess committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    20138d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'master' into php-cs-fixer

    @seasoftjapan
    seasoftjapan authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a14deeb View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Fix phpstan

    @nanasess
    nanasess committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    7690b1a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into php-cs-fixer

    @nanasess
    nanasess authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    b3df010 View commit details
    Browse the repository at this point in the history