Use FileUtils instead of raw shell commands

ELIXIR-Belgium · Jun 20, 2024 · 1ea11b2 · 1ea11b2
1 parent b98f42b
commit 1ea11b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/app/controllers/templates_controller.rb b/app/controllers/templates_controller.rb
@@ -94,7 +94,7 @@ def populate_template
     dir = Seek::Config.append_filestore_path('source_types')
 
     if Dir.exist?(dir)
-      `rm #{dir}/*`
+      FileUtils.delete(Dir.glob("#{dir}/*"))
     else
       FileUtils.mkdir_p(dir)
     end
@@ -172,7 +172,7 @@ def set_status
     elsif File.exist?(resultfile)
       res = File.read(resultfile)
       @status = res
-      `rm #{resultfile}`
+      FileUtils.delete(resultfile)
     else
       @status = 'not_started'
     end
@@ -187,12 +187,12 @@ def resultfile
   end
 
   def running!
-    `touch #{lockfile}`
+    FileUtils.touch(lockfile)
     set_status
   end
 
   def done!
-    `rm -f #{lockfile}`
+    FileUtils.delete(lockfile)
   end
 
   def running?

diff --git a/lib/seek/isa_templates/template_extractor.rb b/lib/seek/isa_templates/template_extractor.rb
@@ -4,7 +4,7 @@ module Seek
   module IsaTemplates
     module TemplateExtractor
       def self.extract_templates
-        `touch #{resultfile}`
+        FileUtils.touch(resultfile)
         result = StringIO.new
         seed_isa_tags