Fix composition text color #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
等等，這樣改的話變成小畫家會有問題了。可能要設法比較兩種顏色哪一個跟背景的反差較大然後再採用才行。 |
|
嗯，不行，更糟糕的是在淺色模式當中這個 PR 的寫法根本反而會導致錯誤的結果。看起來還要再多研究才行了。 |
|
啊，原來解答就是根本把設定顏色那幾列程式碼去掉、讓系統自己去安排顏色就好了。至少這樣一來在 Win11 上面測試無論是深色淺色主題在記事本、小畫家或其它已知的應用程式中都是正確的。 不太確定當初寫上那幾列是否在舊的系統中是必要的？可能要看看有沒有辦法在舊系統上測試了。 |
|
這個問題在1.3.0-stable還是存在。 |
|
应该用TF_CT_NONE，由应用自行决定颜色 |
去掉的的話不也是一樣地由應用程式自行決定顏色？ |
你这个pr上的是 |
|
@fxliang 你應該是看到第一個 commit 去了，我第二個是改成直接拿掉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個 PR 是為了修正 EasyIME/PIME#698 ，把兩個參數修改之後，用編譯出來的 PIMETextService.dll 取代掉原本的檔案測試執行真的可以正確輸入：
或者在 VS Code 當中輸入時也會跟當前的程式碼顏色一致：