Skip to content

Commit

Permalink
Use a file with test-fixtures-windows expected failures
Browse files Browse the repository at this point in the history
Instead of retrieving them from GitoxideLabs#1358. (See discussion in GitoxideLabs#1663.)
  • Loading branch information
EliahKagan committed Nov 9, 2024
1 parent 067e7d2 commit 99238a7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 18 deletions.
19 changes: 1 addition & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,29 +109,12 @@ jobs:
Write-Output $actual_failures
Set-Content -Path 'actual-failures.txt' -Value $actual_failures
- name: Collect expected failures
env:
GH_TOKEN: ${{ github.token }}
run: |
$issue = 1358 # https://github.com/GitoxideLabs/gitoxide/issues/1358
$match_info = gh issue --repo GitoxideLabs/gitoxide view $issue --json body --jq .body |
Out-String |
Select-String -Pattern '(?s)```text\r?\n(.*?)```'
$expected_failures = $match_info.Matches.Groups[1].Value -split "`n" |
Where-Object { ($_ -match '^\s*FAIL \[') -and ($_ -notmatch '\bperformance\b') } |
ForEach-Object { $_ -replace '^\s*FAIL \[\s*\d+\.\d+s\]\s*', '' -replace '\s+$', '' } |
Sort-Object
Write-Output $expected_failures
Set-Content -Path 'expected-failures.txt' -Value $expected_failures
- name: Compare expected and actual failures
run: |
# Fail on any differences, even unexpectedly passing tests, so they can be investigated.
# (If the job is made blocking for PRs, it may make sense to make this less stringent.)
git --no-pager diff --no-index --exit-code --unified=1000000 --color=always -- `
expected-failures.txt actual-failures.txt
etc/test-fixtures-windows-expected-failures-see-issue-1358.txt actual-failures.txt
test-32bit:
runs-on: ubuntu-latest
Expand Down
14 changes: 14 additions & 0 deletions etc/test-fixtures-windows-expected-failures-see-issue-1358.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
gix-glob::glob pattern::matching::compare_baseline_with_ours
gix-pathspec::pathspec parse::baseline
gix-pathspec::pathspec parse::valid::glob_negations_are_always_literal
gix-pathspec::pathspec parse::valid::whitespace_in_pathspec
gix-pathspec::pathspec search::files
gix-pathspec::pathspec search::prefixes_are_always_case_sensitive
gix-submodule::submodule file::baseline::common_values_and_names_by_path
gix-submodule::submodule file::is_active_platform::pathspecs_matter_even_if_they_do_not_match
gix-submodule::submodule file::is_active_platform::submodules_with_active_config_are_considered_active_or_inactive
gix-submodule::submodule file::is_active_platform::submodules_with_active_config_override_pathspecs
gix-submodule::submodule file::is_active_platform::without_any_additional_settings_all_are_inactive_if_they_have_a_url
gix-submodule::submodule file::is_active_platform::without_submodule_in_index
gix::gix revision::spec::from_bytes::regex::find_youngest_matching_commit::regex_matches
gix::gix revision::spec::from_bytes::regex::with_known_revision::contained_string_matches_in_unanchored_regex_and_disambiguates_automatically

0 comments on commit 99238a7

Please sign in to comment.