Merge pull request #72 from Exabyte-io/feat/SOF-6749

feat/SOF-6749: modify extendAndPatchRegistry to support default values
Exabyte-io · Sep 12, 2023 · fb130ad · fb130ad
2 parents 515ef1c + 81a9137
commit fb130ad
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 4 deletions.
diff --git a/src/context/registry.js b/src/context/registry.js
@@ -46,13 +46,27 @@ export class ContextProviderRegistryContainer {
  * };
  *
  */
-export const extendAndPatchRegistry = (registryContainer, classConfigMap, classesToPatch = {}) => {
+export const extendAndPatchRegistry = (
+    registryContainer,
+    classConfigMap,
+    classesToPatch = {},
+    defaultSettings = {},
+) => {
     Object.entries(classConfigMap).forEach(([name, { providerCls, config }]) => {
         Object.entries(classesToPatch).forEach(([clsName, cls]) => {
             if (providerCls[clsName]) {
                 providerCls[clsName] = cls;
             }
+            const providerDefaultSettings = defaultSettings[providerCls.name];
+            if (providerDefaultSettings) {
+                Object.entries(providerDefaultSettings).forEach(([key, value]) => {
+                    if (providerCls[key]) {
+                        providerCls[key] = value;
+                    }
+                });
+            }
         });
+
         registryContainer.addProvider({
             instance: providerCls.getConstructorConfig(config),
             name,
@@ -66,7 +80,16 @@ export const extendAndPatchRegistry = (registryContainer, classConfigMap, classe
  * @param {Object} classConfigMap
  * @param {{Material: SpecificMockMaterial}} classesToPatch
  */
-export const createAndPatchRegistry = (classConfigMap, classesToPatch = {}) => {
+export const createAndPatchRegistry = (
+    classConfigMap,
+    classesToPatch = {},
+    defaultSettings = {},
+) => {
     const registryContainer = new ContextProviderRegistryContainer();
-    return extendAndPatchRegistry(registryContainer, classConfigMap, classesToPatch);
+    return extendAndPatchRegistry(
+        registryContainer,
+        classConfigMap,
+        classesToPatch,
+        defaultSettings,
+    );
 };
diff --git a/tests/context.tests.ts b/tests/context.tests.ts
@@ -36,6 +36,8 @@ class ProviderEntity extends MaterialContextMixin(ApplicationContextMixin(Contex
     static Material = MockMaterial;
 
     static Application = MockApplication;
+
+    static setting = 10;
 }
 
 class DerivedProviderEntity extends ProviderEntity {
@@ -76,12 +78,24 @@ describe("ContextProviderRegistryContainer", () => {
         },
     };
 
+    const defaultSettings = {
+        ProviderEntity: {
+            setting: 100,
+        },
+    };
+
     it("can be created and patched", () => {
-        const registry = createAndPatchRegistry(classConfigObj, { Material: SpecificMockMaterial });
+        const registry = createAndPatchRegistry(
+            classConfigObj,
+            { Material: SpecificMockMaterial },
+            defaultSettings,
+        );
+
         const _dataProvider = registry.findProviderInstanceByName("DataManager");
         const dataProvider = new _dataProvider.constructor(_dataProvider.config);
         const _appProvider = registry.findProviderInstanceByName("ApplicationDataManager");
         const appProvider = new _appProvider.constructor(_appProvider.config);
+        expect(_dataProvider.constructor.setting).to.be.equal(100);
         expect(dataProvider.material).to.be.equal("defaultSpecificMockMaterial");
         expect(appProvider.application).to.be.equal("defaultSpecificMockApplication");
     });