Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for MSVC 1940 & 1941, CMake 3.30, Github Actions Node16 #1225

Merged
merged 14 commits into from
Sep 4, 2024
Merged

Fixes for MSVC 1940 & 1941, CMake 3.30, Github Actions Node16 #1225

merged 14 commits into from
Sep 4, 2024

Commits on Aug 22, 2024

  1. CMake: Short term fix for policy CMP0169 

    Sets policy CMP0169 to OLD to prevent dev warnings related to FetchContent_Populate(<name>).

This needs fixing propperly for longer term support, see #1223
    @ptheywood
    ptheywood committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9e528a4 View commit details
    Browse the repository at this point in the history

  2. CMake: Warn about MSVC >= 1940 and CUDA <= 12.3 incompatibility with … 

    …suggestion
    @ptheywood
    ptheywood committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c1ccf8b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. CI: MSVC 1940 + CUDA <= 12.3 fix in Windows.yml CI via CUDAFLAGS

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    638f556 View commit details
    Browse the repository at this point in the history

  2. CI: regular CI matrix update to include CUDA 12.6 

    The regular linux and windows workflows now include:

+ Latest CUDA (12.6)
  + release no vis
  + release vis
  + beltsoff no vis
  + beltsoff vis
+ CUDA 12.0
  + release no vis
+ CUDA 11.8
  + release no vis
  + release vis
+ CUDA 11.0
  + release no vis

This is a compromise to cover a wider set of configurations, without increasing CI demand too much
    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7f98d72 View commit details
    Browse the repository at this point in the history

  3. CI: Temporary workaround for manylinux2014 containers glibc error 

    Github switched from Node 16 to Node 20 for Github actions runners on 2024-06-03.
This is incompatble with older linux distributions, including centos7.

This sets an env var which will alllow the use of node 16, but this will stop working at some point when github fully remove node 16.

This is separate but related to #1224
    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    85ef8ae View commit details
    Browse the repository at this point in the history

  4. Examples: Fix missing include for FLT_MAX in circles examples using C… 

    …UDA 12.5

Closes #1216
    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dfcfb72 View commit details
    Browse the repository at this point in the history

  5. CI: Update Windows-Tests manual CI with additional MSVC 1940 fix and … 

    …CUDA 12.6
    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5957ea1 View commit details
    Browse the repository at this point in the history

  6. CI: Fix comments in Ubuntu.yml

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    19def83 View commit details
    Browse the repository at this point in the history

  7. CI: Draft release thoroguh ubuntu build CUDA update and comment fixes

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c0cac32 View commit details
    Browse the repository at this point in the history

  8. CI: Draft Release MSVC 1940 fix + thorough build cuda tweak

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5a0a77a View commit details
    Browse the repository at this point in the history

  9. CI: Draft release Manylinux2014 Node version fix

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    442993b View commit details
    Browse the repository at this point in the history

  10. CMake: Update visualisation repo hash to include MSVC, CMake & CI fixes

    @ptheywood
    ptheywood committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    84388eb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. CMake: Add MSVC 1941/VS2022 17.11 warning about requiring CUDA 12.4 o… 

    …r newer
    @ptheywood
    ptheywood committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e5fb1ed View commit details
    Browse the repository at this point in the history

  2. CI: Switch to VS 2019 for CUDA <= 12.3 workflows due to MSVC STL change

    @ptheywood
    ptheywood committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7e95593 View commit details
    Browse the repository at this point in the history