add ALLOW_PLAYER_CHANGE_WORLD #4104
Conversation
| @@ -64,6 +64,16 @@ public void onInitialize() { | |||
| LOGGER.info("Entity {} Killed: {}", entity, killed); | |||
| }); | |||
|
|
|||
| ServerEntityWorldChangeEvents.ALLOW_PLAYER_CHANGE_WORLD.register((player, origin, destination) -> { | |||
| if (player.getStackInHand(Hand.MAIN_HAND).getItem() == Items.END_ROD) { | |||
There was a problem hiding this comment.
Nitpick:
| if (player.getStackInHand(Hand.MAIN_HAND).getItem() == Items.END_ROD) { | |
| if (player.getMainHandStack().isOf(Items.END_ROD)) { |
| */ | ||
| public static final Event<AllowPlayerChange> ALLOW_PLAYER_CHANGE_WORLD = EventFactory.createArrayBacked(AllowPlayerChange.class, callbacks -> (player, origin, destination) -> { | ||
| for (AllowPlayerChange callback : callbacks) { | ||
| if (!callback.allowChangeWorld(player, origin, destination)){ |
There was a problem hiding this comment.
Checkstyle will fail:
| if (!callback.allowChangeWorld(player, origin, destination)){ | |
| if (!callback.allowChangeWorld(player, origin, destination)) { |
fishshi
force-pushed
the
feature/ALLOW_PLAYER_CHANGE_WORLD
branch
from
1fd397d
to
e36f266
Compare
| @@ -75,6 +88,19 @@ public interface AfterEntityChange { | |||
| void afterChangeWorld(Entity originalEntity, Entity newEntity, ServerWorld origin, ServerWorld destination); | |||
| } | |||
|
|
|||
| @FunctionalInterface | |||
| public interface AllowPlayerChange { | |||
There was a problem hiding this comment.
Should this be limited to just players, other entities are allowed to use portals.
I think its also worth looking at 1.21.2 as I know they changed a lot of this teleportation code.
There was a problem hiding this comment.
Yes, this event is currently only used to restrict players when crossing dimensions; other entities are not affected. I believe there are very few scenarios where restricting entities from crossing dimensions would be necessary.
There was a problem hiding this comment.
Additionally, I will read through 1.21.2 as soon as possible, and I may be able to provide feedback by tomorrow.
There was a problem hiding this comment.
I have reviewed the relevant source code for 24w39a, and there are not many changes regarding the dimension-crossing code. Through testing, I can assure you that this event works correctly in the latest version as well.
ALLOW_PLAYER_CHANGE_WORLD: Called when the player's dimension changes to check if the player is allowed to cross dimensions.
solve issue:
#3294 (comment)