forked from fzaninotto/Faker
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sk provider fix #860
Open
MilosM33
wants to merge
8
commits into
FakerPHP:2.0
Choose a base branch
from
devicebusy:sk-provider-fix
base: 2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sk provider fix #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimjansen
requested changes
Feb 12, 2024
src/Provider/sk_SK/Address.php
Outdated
@@ -296,7 +296,7 @@ class Address extends \Faker\Provider\Address | |||
|
|||
protected static $buildingNumber = ['%####', '%###', '%##']; | |||
protected static $streetSuffix = [ | |||
'Alley', 'Avenue', 'Branch', 'Bridge', 'Brook', 'Brooks', 'Burg', 'Burgs', 'Bypass', 'Camp', 'Canyon', 'Cape', 'Causeway', 'Center', 'Centers', 'Circle', 'Circles', 'Cliff', 'Cliffs', 'Club', 'Common', 'Corner', 'Corners', 'Course', 'Court', 'Courts', 'Cove', 'Coves', 'Creek', 'Crescent', 'Crest', 'Crossing', 'Crossroad', 'Curve', 'Dale', 'Dam', 'Divide', 'Drive', 'Drive', 'Drives', 'Estate', 'Estates', 'Expressway', 'Extension', 'Extensions', 'Fall', 'Falls', 'Ferry', 'Field', 'Fields', 'Flat', 'Flats', 'Ford', 'Fords', 'Forest', 'Forge', 'Forges', 'Fork', 'Forks', 'Fort', 'Freeway', 'Garden', 'Gardens', 'Gateway', 'Glen', 'Glens', 'Green', 'Greens', 'Grove', 'Groves', 'Harbor', 'Harbors', 'Haven', 'Heights', 'Highway', 'Hill', 'Hills', 'Hollow', 'Inlet', 'Inlet', 'Island', 'Island', 'Islands', 'Islands', 'Isle', 'Isle', 'Junction', 'Junctions', 'Key', 'Keys', 'Knoll', 'Knolls', 'Lake', 'Lakes', 'Land', 'Landing', 'Lane', 'Light', 'Lights', 'Loaf', 'Lock', 'Locks', 'Locks', 'Lodge', 'Lodge', 'Loop', 'Mall', 'Manor', 'Manors', 'Meadow', 'Meadows', 'Mews', 'Mill', 'Mills', 'Mission', 'Mission', 'Motorway', 'Mount', 'Mountain', 'Mountain', 'Mountains', 'Mountains', 'Neck', 'Orchard', 'Oval', 'Overpass', 'Park', 'Parks', 'Parkway', 'Parkways', 'Pass', 'Passage', 'Path', 'Pike', 'Pine', 'Pines', 'Place', 'Plain', 'Plains', 'Plains', 'Plaza', 'Plaza', 'Point', 'Points', 'Port', 'Port', 'Ports', 'Ports', 'Prairie', 'Prairie', 'Radial', 'Ramp', 'Ranch', 'Rapid', 'Rapids', 'Rest', 'Ridge', 'Ridges', 'River', 'Road', 'Road', 'Roads', 'Roads', 'Route', 'Row', 'Rue', 'Run', 'Shoal', 'Shoals', 'Shore', 'Shores', 'Skyway', 'Spring', 'Springs', 'Springs', 'Spur', 'Spurs', 'Square', 'Square', 'Squares', 'Squares', 'Station', 'Station', 'Stravenue', 'Stravenue', 'Stream', 'Stream', 'Street', 'Street', 'Streets', 'Summit', 'Summit', 'Terrace', 'Throughway', 'Trace', 'Track', 'Trafficway', 'Trail', 'Trail', 'Tunnel', 'Tunnel', 'Turnpike', 'Turnpike', 'Underpass', 'Union', 'Unions', 'Valley', 'Valleys', 'Via', 'Viaduct', 'View', 'Views', 'Village', 'Village', 'Villages', 'Ville', 'Vista', 'Vista', 'Walk', 'Walks', 'Wall', 'Way', 'Ways', 'Well', 'Wells', | |||
'Ulička', 'Ulica', 'Pobočka', 'Most', 'Potok', 'Potoky', 'Hrad', 'Hrady', 'Obchvat', 'Tábor', 'Kaňon', 'Mys', 'Dámkový prístup', 'Centrum', 'Centrá', 'Kruh', 'Kruhy', 'Útes', 'Útesy', 'Klub', 'Spoločný', 'Roh', 'Rohy', 'Kurz', 'Súd', 'Súdy', 'Zátoka', 'Zátoky', 'Potok', 'Polmesiac', 'Hrebeň', 'Križovatka', 'Kríž', 'Zákruta', 'Údolie', 'Priehrada', 'Rozvod', 'Jazda', 'Jazda', 'Jazdy', 'Majetok', 'Majetky', 'Rýchlostná cesta', 'Rozšírenie', 'Rozšírenia', 'Pád', 'Vodopády', 'Trajekt', 'Pole', 'Polia', 'Plochý', 'Ploché', 'Brodiť', 'Brody', 'Les', 'Kováreň', 'Kovárne', 'Rozvetvenie', 'Rozvetvenia', 'Fort', 'Diaľnica', 'Záhrada', 'Záhrady', 'Brána', 'Údolie', 'Údolia', 'Zelený', 'Zelené', 'Háj', 'Háje', 'Prístav', 'Prístavy', 'Prístavisko', 'Výšiny', 'Diaľnica', 'Kopiec', 'Kopce', 'Dutina', 'Záliv', 'Záliv', 'Ostrov', 'Ostrov', 'Ostrovy', 'Ostrovy', 'Ostrovček', 'Ostrovček', 'Križovatka', 'Križovatky', 'Kľúč', 'Kľúče', 'Kopček', 'Kopčeky', 'Jazero', 'Jazerá', 'Pozemok', 'Prístav', 'Cestička', 'Svetlo', 'Svetlá', 'Bochník', 'Zámok', 'Zámky', 'Zámky', 'Chata', 'Chata', 'Slučka', 'Obchodné centrum', 'Panstvo', 'Panstvá', 'Lúka', 'Lúky', 'Priechody', 'Mlyn', 'Mlyny', 'Misie', 'Misie', 'Diaľnica', 'Hore', 'Hora', 'Hora', 'Hory', 'Hory', 'Krč', 'Sad', 'Ovál', 'Nadjazd', 'Park', 'Parky', 'Parkovisko', 'Parkoviská', 'Priesmyk', 'Priechod', 'Chodník', 'Piket', 'Borovica', 'Borovice', 'Miesto', 'Planina', 'Planiny', 'Planiny', 'Námestie', 'Námestie', 'Body', 'Body', 'Prístav', 'Prístav', 'Prístavy', 'Prístavy', 'Prérie', 'Prérie', 'Radiál', 'Rampa', 'Ranč', 'Rýchly', 'Rýchle', 'Oddych', 'Hrebeň', 'Hrebene', 'Rieka', 'Cesta', 'Cesta', 'Cesty', 'Cesty', 'Trasa', 'Rada', 'Rue', 'Beh', 'Miel', 'Miele', 'Pobrežie', 'Pobrežia', 'Nebeská cesta', 'Jar', 'Jarné', 'Jarné', 'Ostruha', 'Ostruhy', 'Námestie', 'Námestie', 'Námestia', 'Námestia', 'Stanica', 'Stanica', 'Stravenue', 'Stravenue', 'Potok', 'Potok', 'Ulica', 'Ulica', 'Ulice', 'Vrchol', 'Vrchol', 'Terasa', 'Priechod', 'Stopa', 'Dráha', 'Cesta', 'Chodník', 'Chodník', 'Tunel', 'Tunel', 'Diaľnica', 'Diaľnica', 'Podchod', 'Zväz', 'Zväzy', 'Údolie', 'Údolia', 'Cesta', 'Viadukt', 'Výhľad', 'Výhľady', 'Dedina', 'Dedina', 'Dediny', 'Mesto', 'Výhľad', 'Výhľad', 'Chôdza', 'Chôdze', 'Stena', 'Cesta', 'Cesty', 'Studňa', 'Studne', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep them in alphabet
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
This PR adds unit tests for the
sk_SK
provider and translates street suffixes into Slovak, addressing issue #672.Review checklist
CHANGELOG.md