Fix the bug in D4RL that the seed parameter is ignored. #223
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug in D4RL that the seed parameter is ignored.
env.seed(seed=seed)
. By adding the two lines ind4rl/locomotion/wrappers.py
, callingenv.seed(seed=seed)
will effectively assign the specified seed to the environment.np.random
is replaced byself.np_random
ind4rl/locomotion/maze_env.py
. Theself.goal_sampler()
retuens a randomly sampled goal position. However, if usingnp.random
, this sample process is not controlled by the seed we set, causing inconsistency in results.Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)