Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Remove mujoco-py based environments at May 2025 #993

Open
1 task done
Kallinteris-Andreas opened this issue Apr 3, 2024 · 4 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@Kallinteris-Andreas
Copy link
Collaborator

Kallinteris-Andreas commented Apr 3, 2024

Proposal

mujoco-py is an old unmaintained version of MuJoCo bindings (mujoco is the new version), and its inclusion in the gymnasium project is causing some issues (the environments that still use that library are v2 and v3 of the MuJoCo environments).

At May 2022 the first mujoco based environments were released (Ant-v4 and other MuJoCo-v4 environments) and they have been a big improvement, but the old environments are still used for reproducibility of old experiments, so we are giving a 3-year period from the release of new environments (1 year after this post) for which we will still support them and include them in the repository, afterward they will be moved to a separate repository and will not be supported.

The mujoco-py environments are considered deprecated until their removal

Motivation

  1. Cython>=3 is not supported with mujoco-py why restricts other libraries that can be used [Proposal] Update cython dependency to cython 3 #921

Pitch

No response

Alternatives

There is the option to create a mujoco-py soft fork PyPI package that just update the build script, but i am choosing to not follow it as an economization of development time

openai/mujoco-py#782

that being said if someone i willing to assist it might happen.

Additional context

Note this also applies https://robotics.farama.org/ environments

Checklist

  • I have checked that there is no similar issue in the repo
@pseudo-rnd-thoughts
Copy link
Member

While I think its a reasonable suggestion to move the mujoco-py environments into another repo such that users can still access them if necessary, gymnasium-robotics would be the most obvious location.

But I don't totally understand the issue for keeping them in the repo?
The problem with cpython is a semi-permentant issue with mujoco-py no matter the location, therefore, this is more a problem for users than the repo imho.

The biggest motivation would be to encourage users to migrate to v4 / v5 through making them no longer part of the easy install

@ReHoss
Copy link

ReHoss commented Apr 25, 2024

+1 since mujoco-py triggers exceptions like below:

Exception: 
You appear to be missing MuJoCo.  We expected to find the file here: /home/mpanchen/.mujoco/mujoco210

Also appearing in #896

@RogerJL
Copy link
Contributor

RogerJL commented Jun 1, 2024

Prior to release of 1.0 would be the perfect time to remove this - no API promises on alfa/beta...
If someone needs backward compatibility they can use old git version of Gymnasium IMHO.

@ffelten
Copy link
Contributor

ffelten commented Oct 24, 2024

Hey,

I think it might be worth to also look at not using a docker container for tests in the workflows after this is done. Might speed up the workflows quite significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants