-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gymnasium v1.0.0 #41
gymnasium v1.0.0 #41
Conversation
…nda-forge-pinning 2024.10.08.09.45.19
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipe/meta.yaml:
|
We can remove the 932.patch as it was merged upstream in Farama-Foundation/Gymnasium#932 . |
|
Reported in conda-forge/proglog-feedstock#2, the proglog dependency is transitive via moviepy dependency. |
Some failures due to missing dependencies:
|
After adding flax:
|
Some tests are failing:
I think this are the same test that we skipped in #36 . |
Can we check these ones out in more detail before skipping please:
I get confused between which mujoco is the opensource one - I think it was |
I think they are failing as those test require an X server or something similar, see #36 (comment) .
Yes, |
The
|
Tests seems to be skipped correctly if I tried on a stock gymnasium and mujoco_py is not installed, there seems to be something strange at the recipe/conda-build level or similar. |
Python 3.9 builds are failing with:
this seems a wrong metadata on the minimum version supported in the jax package, that need to be addressed. |
Other failures seems related to thing we already saw in #36 (comment) .
It can't load OpenGL, probably something related to headless environment or similar.
|
Thanks @traversaro and @h-vetinari for your work, is there anything I can help with? |
Windows failures:
|
I think Python 3.9 builds are still failing due to some errors in packaging metadata in flax:
|
This will be fixed by: |
@pseudo-rnd-thoughts @Kallinteris-Andreas do you have any idea on who to skip just the |
The v2 and v3 robotics environment are mujoco-py, v4 and v5 are mujoco |
The problem is that the |
Ok, I investigated a bit the offscreen rendering situation for mujoco in conda-forge/mujoco-feedstock#66 . In a nutshell, Azure runners on macOS and Windows do not have GPUs, so the system OpenGL is not going to work. mujoco supports the |
Related upstream issue: google-deepmind/mujoco#2164 . |
Regarding the skipping of |
Thanks, I asked just in case you could think of something. I think we can survive with out manual skipping for now. |
Ok, the last failure is a segfault on
this is not the first time we have strange segfaults that only occur in emulation (see conda-forge/jax-feedstock#144), so I think we can just skip this test. |
This fixed the tests on Python 3.9 . |
Ok, as just skipping one or two tests was not working on
The "libgomp.so.1: cannot allocate memory in static TLS block" seems a recurring problem across the web:
The nice news is:
Note that probably the problem is not occurring for |
Amazing, thanks for your hard work @traversaro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚀
Thanks for all the support! |
Fix #39 .
Fix #33 .
Fix #36 .
Fix Farama-Foundation/Gymnasium#1223 .
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11236245327 - please use this URL for debugging.