-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _action_to_direction usage #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the implementation on line 41 instead for it to be Actions.UP.value
as I think this is still clear what is happening but means we don't need to do this conversion step.
I just realised that I have already made this change over in Gymnasium but not here |
Yeah! That's better :) |
To use the _action_to_direction dict, we need to first convert the numerical action (0, 1, 2, 3) to an Enum.
92c7847
into
Farama-Foundation:main
@pseudo-rnd-thoughts Tests seem to be failing. However, it's failing on the installation step. Not sure if it's the changes I introduced in this PR. Thoughts? |
@kir0ul is looking into it so I wouldn't worry about it for now. I don't believe that your PR caused the issue |
The issue was caused by some changes introduced by the Hatchling build backend (pypa/hatch#1089), hopefully PR #5 should fix it. |
Description
To use the _action_to_direction dict, we need to first convert the numerical action (0, 1, 2, 3) to an Enum.
Fixes #3
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)