Merge pull request #12 from FreenameDomains/dev

Fix default options in freename resolver provider
FreenameDomains · Nov 11, 2022 · d0d6db2 · d0d6db2
2 parents 8244ddd + a57d8ea
commit d0d6db2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "web3-domain-resolver",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Web3 Library that enable with just one function to resolve domains on multiple web3 providers such as ENS, UnstoppableDomains and Freename",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/resolver-providers/providers/freename/freename-resolver-provider.ts b/src/resolver-providers/providers/freename/freename-resolver-provider.ts
@@ -14,14 +14,16 @@ import { FreenameMetadata } from "./freename-resolver-provider.types";
 import { FreenameResolverTools } from "./freename-resolver-tools";
 
 export class FreenameResolverProvider extends BaseResolverProvider implements IResolverProvider {
-	constructor(options: { connectionLibrary?: ConnectionLibrary, testMode?: boolean } = { testMode: false }) {
+	constructor(options: { connectionLibrary?: ConnectionLibrary, testMode?: boolean }) {
+
+		const { connectionLibrary, testMode = false } = options;
 
 		const readContractConnections: ContractConnection[] = [];
 		const writeContractConnections: ContractConnection[] = [];
 		const freenameContractConfs = cloneDeep(FREENAME_CONTRACT_CONFS);
 		for (const contractConf of freenameContractConfs) {
-			if (contractConf.test == options.testMode) {
-				const connection = options.connectionLibrary?.getConnection(contractConf.networkName) || DefaultTools.getDefaultConnection(contractConf.networkName, { infuraIfAvailable: true });
+			if (contractConf.test == testMode) {
+				const connection = connectionLibrary?.getConnection(contractConf.networkName) || DefaultTools.getDefaultConnection(contractConf.networkName, { infuraIfAvailable: true });
 				if (contractConf.type == "read") {
 					readContractConnections.push(new ContractConnection(connection, contractConf.address, contractConf.abi));
 				} else if (contractConf.type == "write") {
@@ -74,7 +76,6 @@ export class FreenameResolverProvider extends BaseResolverProvider implements IR
 			}
 			return false;
 		} catch (e) {
-			console.log(e);
 			return false;
 		}
 	}