Fixed: Fullscreen Mode Tweaks

[aliraza556]

Problem:

• We could have the pre-match and in-game fullscreen buttons actually trigger F11 key if possible on click, while still showing the default (Shift+F) hotkeys for the action. This would keep players in fullscreen mode even if pressing Esc, though toggling would need to be done only via F11 or clicking the button, otherwise if combining with Shift+F hotkey, they get an error message; ideally this would get fixed as well 🤞🏻

closes: #2603

Issue ticket number and link:

• Ticket Number: [ 2603 ]
• Link: [ https://github.com/fullscreen mode tweaks [bounty: 6 XTR] #2603 ]

My wallet address is 0x0000000000000000000000000000000000000000

Will add the wallet address soon

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Aug 11, 2024 7:57pm

[aliraza556]

@DreadKnight, Please review this PR.

[aliraza556]

@DreadKnight, I test all browsers. Error is fixed

[DreadKnight]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

[DreadKnight]

@aliraza556 Too bad... code does look good.

[aliraza556]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

I am used window

[aliraza556]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958

[aliraza556]

@DreadKnight, when I click F11, the screen enters fullscreen mode. Then, when I click Shift + F, the screen exits fullscreen and returns to normal view.

[DreadKnight]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958

I don't understand much from the demo as it involves hotkeys and such.
Anyway, quite a few people are confused about the issues and work on something entirely different at times.
So here's how I test: I press on the game's fullscreen button, then I press Esc key and it leaves fullscreen 🐻

[aliraza556]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958

I don't understand much from the demo as it involves hotkeys and such. Anyway, quite a few people are confused about the issues and work on something entirely different at times. So here's how I test: I press on the game's fullscreen button, then I press Esc key and it leaves fullscreen 🐻

@DreadKnight, what exactly do you want? Do you want a fullscreen button for the game, and then pressing the Esc key will exit fullscreen mode?

[DreadKnight]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958

I don't understand much from the demo as it involves hotkeys and such. Anyway, quite a few people are confused about the issues and work on something entirely different at times. So here's how I test: I press on the game's fullscreen button, then I press Esc key and it leaves fullscreen 🐻

@DreadKnight, what exactly do you want? Do you want a fullscreen button for the game, and then pressing the Esc key will exit fullscreen mode?

@aliraza556 The whole idea with this is to not have Esc leave fullscreen, because that's the exact generic browser stuff that we're trying to avoid.

[aliraza556]

@DreadKnight, I test all browsers. Error is fixed

I've tested and no luck. Perhaps this is different based on operating system. I'm on linux.

Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958

I don't understand much from the demo as it involves hotkeys and such. Anyway, quite a few people are confused about the issues and work on something entirely different at times. So here's how I test: I press on the game's fullscreen button, then I press Esc key and it leaves fullscreen 🐻

@DreadKnight, what exactly do you want? Do you want a fullscreen button for the game, and then pressing the Esc key will exit fullscreen mode?

@aliraza556 The whole idea with this is to not have Esc leave fullscreen, because that's the exact generic browser stuff that we're trying to avoid.

@DreadKnight Ok got it.

[aliraza556]

@DreadKnight, Please test

[DreadKnight]

@DreadKnight, Please test

@aliraza556 Tested. No go, Esc still leaves fullscreen. Only way to not leave it is by pressing F11, hence why the idea was to emulate triggering that with the fullscreen button.