Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ensuring the redirect uri is identical across the initial aut… #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2016

…horization code request and the access token request

Fixes - #89

…horization code request and the access token request
)
) {
// Validate the redirect URI. If a redirect URI has been provided on input, it must be identical
if ($input["redirect_uri"] && $input["redirect_uri"] === $authCode->getRedirectUri()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be !== for "fail if redirect_uri is set and is not equal to the stored one"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant