Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Uniform property field naming and extension identifiers #781

Conversation

ErHaWeb
Copy link

@ErHaWeb ErHaWeb commented Apr 22, 2024

This patch ensures that all fields that can occur in properties are written in the same way. In this way, the values are retained when saving and reloading, for example.

In addition, it has been ensured that the extension identifiers expected by the system or recommended in the documentation are used, for example to correct the output of the custom CType.

@github-actions github-actions bot added the bug Something isn't working label Apr 22, 2024
@ErHaWeb ErHaWeb changed the title [BUGFIX] Uniform naming of property fields [BUGFIX] Uniform property field naming and extension identifiers Apr 22, 2024
@PKuhlmay PKuhlmay changed the base branch from v12-load-old-extensions to typo3-12-reactjs April 23, 2024 07:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 23, 2024
@PKuhlmay
Copy link
Collaborator

PKuhlmay commented Apr 23, 2024

Note for me:

The following configurations in ExtensionBuilder.json must be changed.

/modules/0/value/relationGroup/relations/0/propertyIsExcludeField -> excludeField

See: Classes/Configuration/ExtensionBuilderConfigurationManager.php

@PKuhlmay PKuhlmay changed the base branch from typo3-12-reactjs to v12-load-old-extensions April 23, 2024 13:50
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 23, 2024
@PKuhlmay PKuhlmay force-pushed the v12-load-old-extensions branch 2 times, most recently from e973ef6 to 1391582 Compare June 28, 2024 16:14
PKuhlmay and others added 6 commits June 28, 2024 18:14
This patch ensures that all fields that can occur within properties are written in the same way. In this way, values are retained when saving and reloading, for example.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 28, 2024
@PKuhlmay PKuhlmay merged commit 88c4775 into FriendsOfTYPO3:v12-load-old-extensions Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants