Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to improve type safety #803

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Aug 20, 2024

Waiting for #805 and possibly other changes, as this is quite aspiritional.

Work towards and enabled by #746.

Use type safe RegId instead of RegisterId which is just usize. Get rid of WriteRegKey.

This PR tries really hard to uphold full test and branch coverage while removing lots of test code. I'm hoping to split off some of the work to separate PRs to help with reviewing.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@Dentosal Dentosal self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant