fix: fuels dev cleanup not killing node
#3038
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -233,7 +233,6 @@ export const launchNode = async ({ | |||
| } | |||
| childState.isDead = true; | |||
|
|
|||
| removeSideffects(); | |||
There was a problem hiding this comment.
Removing this line caused the issue to go away. I suspect that the root cause of the problem is somewhere in the fuels package because this line didn't cause problems to e.g. launchTestNode. It might be in the interplay between file watchers registered in the dev command and this cleanup function removing the files they're watching, but I couldn't pinpoint the actual root cause. Tried deleting lines I think might be causing it while having this line still on, but to no avail. We can search for the root cause in another issue that's of lesser priority.
The cleanup still happens because of the exit and error event listeners registered on the child above.
| it( | ||
| 'cleans up resources on graceful shutdown', | ||
| async () => { | ||
| using paths = runInit(); |
There was a problem hiding this comment.
The using keyword is great because you don't have to think about where the test might fail so that you run the cleanup if it does fail there. With using, the cleanup will happen automatically both when the test finishes as well as when it throws an error.
CodSpeed Performance ReportMerging #3038 will degrade performances by 54.32%Comparing Summary
Benchmarks breakdown
|
fuels devwithCTRL+C(SIGINT) doesn't killfuel-corenode #2889Summary
Checklist