-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document hidden tx summary methods #3408
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3408 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
/** @hidden */ | ||
/** | ||
* Gets transaction summaries for a given owner/address. | ||
* @param params - The filters to apply to the query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return type here
@@ -42,15 +42,24 @@ import type { | |||
AbiMap, | |||
} from './types'; | |||
|
|||
/** @hidden */ | |||
/** | |||
* Extracts a specific type of receipts from a list of receipts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Extracts a specific type of receipts from a list of receipts. | |
* Extracts a specific type of receipt from a list of receipts. | |
* |
export function getReceiptsByType<T = TransactionResultReceipt>( | ||
receipts: TransactionResultReceipt[], | ||
type: ReceiptType | ||
) { | ||
return (receipts ?? []).filter((r) => r.type === type) as T[]; | ||
} | ||
|
||
/** @hidden */ | ||
/** | ||
* Returns the transaction type's name based on the transaction type enum value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Returns the transaction type's name based on the transaction type enum value. | |
* Returns the transaction type's name based on the transaction type enum value. | |
* |
@@ -137,7 +137,10 @@ export interface GetTransactionsSummariesReturns { | |||
pageInfo: PageInfo; | |||
} | |||
|
|||
/** @hidden */ | |||
/** | |||
* Gets transaction summaries for a given owner/address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Gets transaction summaries for a given owner/address. | |
* Gets transaction summaries for a given owner/address. | |
* |
@@ -356,7 +372,14 @@ export function getContractCallOperations({ | |||
}); | |||
} | |||
|
|||
/** @hidden */ | |||
/** | |||
* Extracts a transfer operation from a transaction receipt, determining the addresses and types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Extracts a transfer operation from a transaction receipt, determining the addresses and types | |
* Extracts a transfer operation from a transaction receipt, determining the addresses and types | |
* |
Coverage Report:
Changed Files:Coverage values did not change👌. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside @danielbate suggestions, this looks good to me
Summary
This PR adds some hidden tx summary methods to the API docs.
Checklist