Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate bech32 addresses #3411

Merged
merged 18 commits into from
Nov 22, 2024
Merged

chore: deprecate bech32 addresses #3411

merged 18 commits into from
Nov 22, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Nov 20, 2024

Release notes

In this release, we:

  • Deprecated the bech32Address type in favour of hexadecimal address format going forward.

Summary

This PR uses adds the deprecated JS-doc tag as well as makes note in the relevant documentation of the deprecation notice.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:31pm
ts-docs ❌ Failed (Inspect) Nov 21, 2024 6:31pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:31pm

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3411 will not alter performance

Comparing mc/chore/deprecate-bech32 (6a0018d) with master (2cef020)

Summary

✅ 18 untouched benchmarks

packages/address/src/address.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR introduce a new b256Address property on the Address class that we can then phase over to?

.changeset/late-pugs-carry.md Show resolved Hide resolved
danielbate
danielbate previously approved these changes Nov 21, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
64.12%(-0.01%) 69.69%(-0.02%) 72.66%(+0%) 64.56%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/address/src/address.ts 90.16%
(-1.36%)
80.55%
(-1.8%)
85.71%
(+0%)
90.32%
(-1.34%)

@nedsalk nedsalk merged commit 27e8808 into master Nov 22, 2024
24 of 25 checks passed
@nedsalk nedsalk deleted the mc/chore/deprecate-bech32 branch November 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate bech32 address format
6 participants