Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enhancements to the project #380

Open
5 of 7 tasks
karambir opened this issue Oct 30, 2019 · 3 comments
Open
5 of 7 tasks

Some enhancements to the project #380

karambir opened this issue Oct 30, 2019 · 3 comments

Comments

@karambir
Copy link
Contributor

karambir commented Oct 30, 2019

I have done a few enhancements to the project here master...karambir:master

I don't think all of them will be useful to you guys but feel-free to chery-pick. Few pointers:

  • Scrap Fabric and use Make as build(-ish?) system.
  • Use Poetry for Python libs dependency management. This is huge improvement. It can also help in managing virtualenv with support from Pyenv.
  • Use Pyenv and NVM to manage multiple python and node versions on per-project basis. Makefile use them to setup and run commands. Developer needs to have these tools setup and activated in shell.
  • Pin Python and PG versions being installed with ansible on servers. This with Poetry and Pyenv helps in having similar python version as on production. Even for Postgres, when only using client(server on RDS), having same client version as RDS helps.
  • A few fixes in ansible tasks. These are small.
  • Also removed a few things like Heroku
  • remove CircleCI.

I am also planning to add more playbooks where instead of having single web/app server, we can have multiple app servers behind load-balancer. This will need some refactoring in ansible roles to support both configurations(single and multiple servers) and use Terraform to deploy whole project from scratch.

@tucosaurus
Copy link
Contributor

Hey @karambir, thanks for reaching out. Your enhancements look great.
We will have to discuss internally regarding what we would want to cherry-pick from this.

Personally, I would really like to see the playbook for multiple app servers behind load balancer since I had been thinking of adding that as well. Please do consider sending in a PR when you are through with it.

@theskumar
Copy link
Member

+1 for using Make instead of fabfile. I've been using Makefile in some project with success and I love the idea of using Makefile.

@tucosaurus
Copy link
Contributor

I will send in a PR soon. Using it in one of my projects as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants