Remove web pack + replace fabric with makefile #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucosaurus
reviewed
May 15, 2020
| SHELL := bash | ||
| .ONESHELL: | ||
|
|
||
| PROJECT_NAME=insights |
There was a problem hiding this comment.
replace with cookiecutter project name ?
|
Should we look to achieve full feature parity with the fabfile ? |
|
Fabric was introduced with keeping in mind the ability to run command on server from local machine. This is now primarily being done with ansible. So we are not looking to do full match with fab in terms of functionality. |
|
@tucosaurus I've updated Makefile to include some more stuff in there. The tests are failing due to travis + postgres issue :( I'm trying to fix that but the current changes can merge irrespective. |
tucosaurus
approved these changes
May 20, 2020
theskumar
added a commit
that referenced
this pull request
Sep 29, 2020
* master: Fix formatting for failed validation for one of the items in ListField (#413) PyTest: Run failed test and then new test cases first (#414) update dependencies to latest (#412) Add "django.contrib.postgres" to list of INSTALLED_APPS docs: improve setup docs on mac docs(): automate generating the latest db schema on deployment in docs (#408) update readme Add artwork chore - upgrade django (#407) feat: upgrade python dependencies to latest stable (#406) Upgrade django 3.0.5 -> 3.0.6 Update documentation (#405) Remove web pack + replace fabric with makefile (#404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on fabric on different machines as Make is installed on most of the machines. Make can be used not just with python but with projects in other languages as well. Webpack is unused for most of the project and was causing maintenance overload.
remove webpack + replace fab with make commands
yes. webpack and fab is unsupported. Make does have it's own learning requirement.
closes: #391
related: #380