Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
RegistryMacro
instance
fieldgetScriptedClassNames
fieldcreateScriptedEntry
fieldparseEntryData
fieldparseEntryDataRaw
fieldEntryMacro
registryInstance
field_fetchData
fieldid
field_data
fieldtoString
fielddestroy
fieldGeneral
Conversation(Registry)
(help wanted) (ISSUE 2)AlbumRegistry
,FreeplayStyleRegistry
,LevelRegistry
,StageRegistry
(help wanted) (ISSUE 3)ISSUE 1 (SOLVED?)
This also happens with other registries.
I know that the macro isn't directly the problem, because I've used a similar macro for a different branch, in which I created my own types of registries. The entries for my registries didn't access
Registry.instance
. This is why I believe that the issue arises fromNoteStyle
callingNoteStyleRegistry.instance
.Update: I've tested it out, and yes my assumption was correct. The use of
instance
in the entry causes the macro not to work.Solution(?): Use
EntryMacro
to create a getter calledregistryInstance
, and use that instead ofRegistry.instance
.ISSUE 2
Conversation
andConversationRegistry
don't use the macro, however,Speaker
andSpeakerRegistry
do use it.I don't know why this error happens.
If we find a solution to this, we might not need the
registryInstance
field anymore.ISSUE 3
This also happens with
FreeplayStyleRegistry
,LevelRegistry
,StageRegistry
.I believe the issue is the order in which the macros are called. The registries that work call the macros in this order:
EntryMacro
RegistryMacro
The ones that don’t work call it in this order:
RegistryMacro
EntryMacro