[BUGFIX] Fix Input Offset interactions with Input Window (+ sustains) #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuppe isn't it odd that opponent windows are already accounted for Like
github-actions
bot
added
medium
|
oops wait wrong implementation? hold on |
|
my bad, completely correct implementation i just forgot to set my binds |
|
All good, ready for review :D |
xenkap
changed the title
|
someone please accept this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very odd that this was already done on the opponent's side, but not the Player's.
Does this PR close any issues? If so, link them below.
#3692, #2382
Briefly describe the issue(s) fixed.
Input Windows would not be offset by Input Offset, only Note Judgement would be. This pull request fixes that.
Include any relevant screenshots or videos.
BEFORE:
2024-10-15.20-22-12.mp4
AFTER:
2024-10-15.20-19-25.mp4
(Recorded on 200ms Input Offset)
(side note: can someone make events responsive to your offset ?? the hey animations are playing too early)ignore, use visual offset on negative side to achieve effect