Refactor Session.virtualfile_in, removing 'extra_arrays'/'required_z' and add 'required_cols' #3369
+178
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f30479.
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
4a4c8cc
to
f1e6aca
Compare
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
f1e6aca
to
9e78da0
Compare
seisman
changed the title
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
a64046a
to
2a1db22
Compare
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
2a1db22
to
b33476c
Compare
seisman
force-pushed
the
refactor/data_kind
branch
from
bca59f5
to
808755d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different implementation to address the points raised in #2744.