Figure.show: Raise ImportError instead of GMTError if IPython is not installed but required #3580
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…installed but required
seisman
added
enhancement
michaelgrund
approved these changes
Nov 5, 2024
michaelgrund
added
final review call
yvonnefroehlich
approved these changes
Nov 5, 2024
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When
Figure.show(method="notebook")is called but IPython is not installed, we raise theGMTErrorexception, which is the base class for all GMT-related errors.Raising such a low-level, base exception is usually not good. Instead, we should raise
ImportErrorexception in this case.