Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result_images folder to gitignore and make clean list #592

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 8, 2020

Description of proposed changes

Tell git to ignore PNG files in 'result_images' folder, and add it to list of folders to clean for make clean. Patches #555.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 8, 2020
@weiji14 weiji14 merged commit f59fd80 into master Sep 8, 2020
@weiji14 weiji14 deleted the clean_result_images branch September 8, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants