Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, Build and DOC updates #142

Merged
merged 42 commits into from
Mar 27, 2020
Merged

CI, Build and DOC updates #142

merged 42 commits into from
Mar 27, 2020

Conversation

MuellerSeb
Copy link
Member

This PR is a first step for #136 containing:

  • building wheels with cibuildwheel
  • created a GeoStat Logo for PyKrige
  • drop py2 support
  • added support for py38
  • cython now required

@MuellerSeb MuellerSeb added this to the 1.5 milestone Mar 26, 2020
@MuellerSeb MuellerSeb self-assigned this Mar 26, 2020
@MuellerSeb MuellerSeb requested a review from rth March 26, 2020 16:02
Copy link
Contributor

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks @MuellerSeb ! LGTM, aside for a few comments below, after fairly superficial review.

I think we should make one last Python 2 supporting release (1.4.2) from the current master before this is merged. Last release was in Jan 15, 2019.

.travis.yml Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
pykrige/lib/lapack.pyx Show resolved Hide resolved
doc/Makefile Show resolved Hide resolved
tests/test_regression_krige.py Show resolved Hide resolved
@MuellerSeb
Copy link
Member Author

I would argue against a last py2 release, because since v1.4.1 only two commits have been made to master, both to bring the GSTools interface. And In GSTools we just dropped py2 support. I think 1.4.1 is ok as a last py2 release.

@rth
Copy link
Contributor

rth commented Mar 27, 2020

I would argue against a last py2 release, because since v1.4.1 only two commits have been made to master, both to bring the GSTools interface.

Fair enough.

Free free to merge on green CI. Thanks!

@MuellerSeb
Copy link
Member Author

Wheels are build correctly and update to test.pypi was successful. Docs building correct. Tests are successful.
Squashing and merging.

See:

@MuellerSeb MuellerSeb merged commit 39f7097 into develop Mar 27, 2020
@MuellerSeb MuellerSeb deleted the CI_update branch March 27, 2020 20:37
@MuellerSeb MuellerSeb mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants