Rename VcsProvider, refactor async method names

GitTools · Jul 31, 2020 · 293164c · 293164c
1 parent 1f53737
commit 293164c
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/Source/GitReleaseManager.Cli/Program.cs b/Source/GitReleaseManager.Cli/Program.cs
@@ -199,7 +199,7 @@ private static async Task<int> CloseMilestoneAsync(CloseSubOptions subOptions)
             Log.Information("Closing milestone {Milestone}", subOptions.Milestone);
             _vcsProvider = GetVcsProvider(subOptions);
 
-            await _vcsProvider.CloseMilestone(subOptions.RepositoryOwner, subOptions.RepositoryName, subOptions.Milestone).ConfigureAwait(false);
+            await _vcsProvider.CloseMilestoneAsync(subOptions.RepositoryOwner, subOptions.RepositoryName, subOptions.Milestone).ConfigureAwait(false);
 
             return 0;
         }
@@ -258,7 +258,7 @@ private static async Task<int> CreateLabelsAsync(LabelSubOptions subOptions)
             Log.Information("Creating standard labels");
             _vcsProvider = GetVcsProvider(subOptions);
 
-            await _vcsProvider.CreateLabels(subOptions.RepositoryOwner, subOptions.RepositoryName).ConfigureAwait(false);
+            await _vcsProvider.CreateLabelsAsync(subOptions.RepositoryOwner, subOptions.RepositoryName).ConfigureAwait(false);
             return 0;
         }
 

diff --git a/Source/GitReleaseManager.Tests/FakeGitHubClient.cs b/Source/GitReleaseManager.Tests/FakeGitHubClient.cs
@@ -98,7 +98,7 @@ public Task<string> ExportReleases(string owner, string repository, string tagNa
             throw new System.NotImplementedException();
         }
 
-        public Task CloseMilestone(string owner, string repository, string milestoneTitle)
+        public Task CloseMilestoneAsync(string owner, string repository, string milestoneTitle)
         {
             throw new System.NotImplementedException();
         }
@@ -113,7 +113,7 @@ public Task PublishRelease(string owner, string repository, string tagName)
             throw new System.NotImplementedException();
         }
 
-        public Task CreateLabels(string owner, string repository)
+        public Task CreateLabelsAsync(string owner, string repository)
         {
             throw new System.NotImplementedException();
         }

diff --git a/Source/GitReleaseManager/VcsProvider.cs → Source/GitReleaseManager/BaseVcsProvider.cs b/Source/GitReleaseManager/VcsProvider.cs → Source/GitReleaseManager/BaseVcsProvider.cs
@@ -10,9 +10,9 @@ namespace GitReleaseManager.Core
     using GitReleaseManager.Core.Model;
     using Serilog;
 
-    public abstract class VcsProvider : IVcsProvider
+    public abstract class BaseVcsProvider : IVcsProvider
     {
-        public VcsProvider(Config configuration, ILogger logger)
+        public BaseVcsProvider(Config configuration, ILogger logger)
         {
             Configuration = configuration;
             Logger = logger;
@@ -24,7 +24,7 @@ public VcsProvider(Config configuration, ILogger logger)
 
         public abstract Task AddAssets(string owner, string repository, string tagName, IList<string> assets);
 
-        public abstract Task CloseMilestone(string owner, string repository, string milestoneTitle);
+        public abstract Task CloseMilestoneAsync(string owner, string repository, string milestoneTitle);
 
         public abstract Task<Release> CreateReleaseFromInputFile(string owner, string repository, string name, string inputFilePath, string targetCommitish, IList<string> assets, bool prerelease);
 
@@ -50,7 +50,7 @@ public VcsProvider(Config configuration, ILogger logger)
 
         public abstract Task PublishRelease(string owner, string repository, string tagName);
 
-        public virtual async Task CreateLabels(string owner, string repository)
+        public virtual async Task CreateLabelsAsync(string owner, string repository)
         {
             if (Configuration.Labels.Any())
             {

diff --git a/Source/GitReleaseManager/GitHubProvider.cs b/Source/GitReleaseManager/GitHubProvider.cs
@@ -284,7 +284,7 @@ public Task<string> ExportReleases(string owner, string repository, string tagNa
             return releaseNotesExporter.ExportReleaseNotes(tagName);
         }
 
-        public async Task CloseMilestone(string owner, string repository, string milestoneTitle)
+        public async Task CloseMilestoneAsync(string owner, string repository, string milestoneTitle)
         {
             _logger.Verbose("Finding open milestone with title '{Title}' on '{Owner}/{Repository}'", milestoneTitle, owner, repository);
             var milestoneClient = _gitHubClient.Issue.Milestone;
@@ -341,7 +341,7 @@ public async Task PublishRelease(string owner, string repository, string tagName
             await _gitHubClient.Repository.Release.Edit(owner, repository, release.Id, releaseUpdate).ConfigureAwait(false);
         }
 
-        public async Task CreateLabels(string owner, string repository)
+        public async Task CreateLabelsAsync(string owner, string repository)
         {
             if (_configuration.Labels.Any())
             {

diff --git a/Source/GitReleaseManager/GiteaProvider.cs b/Source/GitReleaseManager/GiteaProvider.cs
@@ -12,7 +12,7 @@ namespace GitReleaseManager.Core
     using GitReleaseManager.Core.Extensions;
     using Serilog;
 
-    public class GiteaProvider : VcsProvider
+    public class GiteaProvider : BaseVcsProvider
     {
         private readonly IssueApi _api;
 
@@ -34,7 +34,7 @@ public override Task AddAssets(string owner, string repository, string tagName,
             throw new NotImplementedException();
         }
 
-        public override async Task CloseMilestone(string owner, string repository, string milestoneTitle)
+        public override async Task CloseMilestoneAsync(string owner, string repository, string milestoneTitle)
         {
             Logger.Verbose("Finding open milestone with title '{Title}' on '{Owner}/{Repository}'", milestoneTitle, owner, repository);
 

diff --git a/Source/GitReleaseManager/IVcsProvider.cs b/Source/GitReleaseManager/IVcsProvider.cs
@@ -35,12 +35,12 @@ public interface IVcsProvider
 
         Task<string> ExportReleases(string owner, string repository, string tagName);
 
-        Task CloseMilestone(string owner, string repository, string milestoneTitle);
+        Task CloseMilestoneAsync(string owner, string repository, string milestoneTitle);
 
         Task OpenMilestone(string owner, string repository, string milestoneTitle);
 
         Task PublishRelease(string owner, string repository, string tagName);
 
-        Task CreateLabels(string owner, string repository);
+        Task CreateLabelsAsync(string owner, string repository);
     }
 }