Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-271) Move classes into extensions folder #272

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Aug 24, 2020

Description

Consolidate all extension classes into the extensions folder.
For consistency.

Fixes #271

Related Issue

#271

Motivation and Context

To safe our sanity

How Has This Been Tested?

It hasn't, pushing to CI build

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

To be consistent with where another extension class lives
@codecov-commenter
Copy link

Codecov Report

Merging #272 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #272   +/-   ##
========================================
  Coverage    77.20%   77.20%           
========================================
  Files           54       54           
  Lines         1132     1132           
  Branches       135      135           
========================================
  Hits           874      874           
  Misses         237      237           
  Partials        21       21           
Impacted Files Coverage Δ
...easeManager.Core/Extensions/MilestoneExtensions.cs 0.00% <ø> (ø)
...eleaseManager.Core/Extensions/OctokitExtensions.cs 0.00% <ø> (ø)
...leaseManager.Core/MappingProfiles/GitHubProfile.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31af1f5...ba96512. Read the comment docs.

@gep13 gep13 merged commit 22c6f53 into GitTools:develop Aug 24, 2020
@gep13 gep13 deleted the feature/GH-271 branch August 24, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Extension classes to the Extensions folder
2 participants