Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-356) Remove file header #357

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

Witteborn
Copy link
Contributor

Description

I searched for the file header (ctrl + f: "// ---") and removed every one I found.

Related Issue

Resolves #356
This is also part of the issue #261

Motivation and Context

As mentioned in #261

Classes in the GitVersion project don't contain any file header. A class rename don't change the filename in the header, which cause a warning and increases the maintenance effort.

How Has This Been Tested?

I did not change any actual code.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I could not pass the integration tests and I'm not sure why.
They didn't pass before and after the change.

@codecov-io
Copy link

Codecov Report

Merging #357 (7b0cdd7) into develop (3165c9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #357   +/-   ##
========================================
  Coverage    78.88%   78.88%           
========================================
  Files           57       57           
  Lines         1274     1274           
  Branches       160      160           
========================================
  Hits          1005     1005           
  Misses         247      247           
  Partials        22       22           
Impacted Files Coverage Δ
...tReleaseManager.Core/Attributes/SampleAttribute.cs 100.00% <ø> (ø)
.../GitReleaseManager.Core/AutoMapperConfiguration.cs 0.00% <ø> (ø)
...itReleaseManager.Core/Commands/AddAssetsCommand.cs 100.00% <ø> (ø)
...rc/GitReleaseManager.Core/Commands/CloseCommand.cs 100.00% <ø> (ø)
...c/GitReleaseManager.Core/Commands/CreateCommand.cs 100.00% <ø> (ø)
.../GitReleaseManager.Core/Commands/DiscardCommand.cs 100.00% <ø> (ø)
...c/GitReleaseManager.Core/Commands/ExportCommand.cs 100.00% <ø> (ø)
src/GitReleaseManager.Core/Commands/InitCommand.cs 26.92% <ø> (ø)
...rc/GitReleaseManager.Core/Commands/LabelCommand.cs 100.00% <ø> (ø)
src/GitReleaseManager.Core/Commands/OpenCommand.cs 100.00% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3165c9d...7b0cdd7. Read the comment docs.

@Witteborn Witteborn changed the title (GH-356) Remove the file header (GH-356) Remove file header Mar 6, 2021
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Mar 8, 2021

@Witteborn thank you very much for taking the time to update this. I agree that the current copyright header makes refactoring the code difficult. At some point, we may add back in an alternative copyright header, but for now, removing what is currently in place, makes a lot of sense.

@gep13 gep13 merged commit 686ffe2 into GitTools:develop Mar 8, 2021
gittools-bot pushed a commit that referenced this pull request Mar 8, 2021
Merge pull request #357 from Witteborn/feature/GH-356

(GH-356) Remove file header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove file header
3 participants