Refactoring/remove the EffectiveConfiguration property in the GitVersionContext class

[HHobeck]

Description

Refactoring/remove the EffectiveConfiguration property in the GitVersionContext class. This change is a preparation for fixing the issue #3101 in PR #3190 and targets the v5 version. No business logic changed.

Related Issue

[Bug] Version not generated correct when creating a feature branch from a release branch #3101

Motivation and Context

This PR is a preparation for PR #3190 and should be integrated in v5.

How Has This Been Tested?

All unit and integration tests have been executed.

Screenshots (if appropriate):

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[HHobeck]

Hi @asbjornu and @arturcic. Do you have an idea why the CI pipeline not passing?

CodeQL / Analyze (csharp) (pull_request):

  ========================================
  CodeFormat
  ========================================
  Code format...
  Unrecognized command or argument '-p:UseSharedCompilation=false'.
  Unrecognized command or argument '-p:UseSharedCompilation=false'.
  
  Description:
    Formats code to match editorconfig settings.
  
  Usage:
  format [<The project or solution file to operate on. If a file is not specified, the command will search the current directory for one.>] [command] [options]

CI / Unit Test code (windows-latest, net5.0) (pull_request):

Error: unknown test file type for 'artifacts/test-results/GitVersion.MsBuild.Tests.net5.0.results.xml'

[arturcic]

I will check this one

[arturcic]

@HHobeck seems like recently codeql changed a bit the way they run the build so I had to fix that. You will need to rebase on top of support/5.x to have this fixed

[asbjornu]

@arturcic, we also have a problem with the Test Summary step:

Error: unknown test file type for 'artifacts/test-results/GitVersion.App.Tests.net48.results.xml'

I think the issue may be that that the test-summary action does not support NUnit test reports. Perhaps we should just remove the Test Summary step until test-summary/action#12 is resolved?

[asbjornu]

Thank you so much for your hard work on this @HHobeck! It is much appreciated. 🙏🏼 Please have a look at my review comments. As soon as they are resolved and the tests are fixed, I think this should be merged. Then we'll do a merge of support/5.x into main so you can rebase #3190 on top of the great work you've done here.

[asbjornu]

👏🏼 Now we just need to figure out what to do with the failing Test Summary task. Thoughts @arturcic?

[arturcic]

👏🏼 Now we just need to figure out what to do with the failing Test Summary task. Thoughts @arturcic?

The interesting thing is on main the Test summary works just fine, sometimes the macos is failing but on rerun it's ok

[asbjornu]

The interesting thing is on main the Test summary works just fine, sometimes the macos is failing but on rerun it's ok

Is it really fine, or does it work when artifacts/test-results/*.results.xml returns no files, while it fails when it does?

[arturcic]

The interesting thing is on main the Test summary works just fine, sometimes the macos is failing but on rerun it's ok

Is it really fine, or does it work when artifacts/test-results/*.results.xml returns no files, while it fails when it does?

if you check this run for example https://github.com/GitTools/GitVersion/actions/runs/3173292935 you will see 5 test summaries for every platform excluding macos + netcore3.1

[HHobeck]

The interesting thing is on main the Test summary works just fine, sometimes the macos is failing but on rerun it's ok

Is it really fine, or does it work when artifacts/test-results/*.results.xml returns no files, while it fails when it does?

if you check this run for example https://github.com/GitTools/GitVersion/actions/runs/3173292935 you will see 5 test summaries for every platform excluding macos + netcore3.1

What does this mean? I can see the following error:

Run test-summary/action@v1
Error: unknown test file type for 'artifacts/test-results/GitVersion.MsBuild.Tests.net5.0.results.xml'

On the main branch this error seems to be not existing.

[arturcic]

@HHobeck I think on support branch we can disable the test-summary action, so please rebase again on support branch, I disabled it there

[HHobeck]

@HHobeck I think on support branch we can disable the test-summary action, so please rebase again on support branch, I disabled it there

No problem I can do this. Please let me know if you have changed it.

[arturcic]

@HHobeck you can rebase it now

[arturcic]

@HHobeck you don't need to push new commits to re-trigger the failed unit test step. I can retrigger it

[HHobeck]

Thank you very much @arturcic and @asbjornu for your input and the good team work. After the code base has been merged to the support/5.x branch we need to merge it to the master branch right?

[arturcic]

Yes, that is the plan

[mergify]

Thank you @HHobeck for your contribution!

[arturcic]

🎉 This issue has been resolved in version 5.11.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀