gix-protocol::fetch() without Delegates
#1634
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done with a test-only function that is siimlar the current `fetch()` one, performing the whole operation from start to finish, while allowing to override individual steps just enough to make it work.
Byron
force-pushed
the
remove-delegates
branch
from
d1717c3
to
c7d477d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having learned from
gixit should now be possible to have a command-orientedfetchthat is similar to
gix_protocol::ls_refs().Motivated by #1319, as these changes should allow
heartwoodto use most ofgix-protocolwithout duplicating a lot of code.
Tasks
fetch()test-onlyfetch()as command similar tols_refs(), based ongixfetchwith the command-oriented fetch, maybe provide itas utility in
gix-protocoleven? That would allow the Delegates to remain, butbe specific to this particularly 'simple' way of performing a fetch.
gixuse the command-oriented fetch.