Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateware.clockgen: Fix off-by-one error #668

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mbikovitsky
Copy link

This addresses #667.

  • The off-by-one in ClockGen.derive and ClockGen.calculate is fixed.
  • stb_r and stb_f in the half-frequency special case are fixed to behave identically to the general case.
    • I'm not sure whether this will break existing applets, so this change can be removed.
  • Tests are added for the new behaviour.

Previously, the strobe would occur one cycle before the output
edge, while in the general case the strobe happens on the
same cycle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant