Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Update pFUnit to use v2 template interfaces #464

Closed

Conversation

cferenba
Copy link
Contributor

@cferenba cferenba commented May 20, 2024

This adds the changes needed for pFUnit to build using the v2 versions of the template interfaces.

Note that this PR depends on Goddard-Fortran-Ecosystem/fArgParse#142 and will not build without it.

Resolves #463.

@cferenba cferenba requested a review from tclune as a code owner May 20, 2024 20:12
@cferenba cferenba marked this pull request as draft May 20, 2024 20:12
@cferenba
Copy link
Contributor Author

Sorry, I got pulled aside to other things and haven't gotten back to this. @tclune please review...

@tclune
Copy link
Member

tclune commented Jun 3, 2024

Same here. Vacation combined with official travel. I have the ticket pegged in my inbox. Hopefully can review sometime this week. Quite jet-lagged at the moment though.

@cferenba
Copy link
Contributor Author

cferenba commented Jun 3, 2024

Quite jet-lagged at the moment though.

Understood. Whenever you are able to get to it is fine.

@tclune
Copy link
Member

tclune commented Jun 17, 2024

@cferenba Sorry for the delay. Finally got around to reviewing. Looks fine but CI looks to have had a weird issue. I'll discuss with my software stack person (@mathomp4) tomorrow.

@cferenba
Copy link
Contributor Author

Looks like the CI is looking for an fArgParse hash that is in Goddard-Fortran-Ecosystem/fArgParse#142 but isn't in develop yet.

@tclune
Copy link
Member

tclune commented Jun 18, 2024

Looks like the CI is looking for an fArgParse hash that is in Goddard-Fortran-Ecosystem/fArgParse#142 but isn't in develop yet.

Yeah - should have read the "conversation" rather than just staring at the changes. I've approved the fArgParse PR, but you'll need to at least touch the ChangeLog for CI to be happy there. If the branch were local I would have done that for you.

@tclune tclune marked this pull request as ready for review July 9, 2024 18:04
@tclune tclune mentioned this pull request Jul 9, 2024
@tclune
Copy link
Member

tclune commented Jul 9, 2024

I've created a new PR that brings in your changes to fArgParse. Closing this one.

@tclune tclune closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants