Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update to actions/deploy-pages@v4 #193

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jul 17, 2024

I don't know if this is related to the recent documentation deployment failures, but I just noticed we were using v1 of the actions/deploy-pages action, when the latest is v4.

Unfortunately, this job will only run on the master branch, so the tests on this PR won't tell us if it works or not.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jul 17, 2024

Ah, it's definitely not related. I just re-ran the docs deployment job that failed and it succeeded. I'm guess it was a momentary hiccup from GitHub Pages.

We should still do this update, though, because v1 is deprecated, and will eventually no longer work.

@m4gr3d m4gr3d merged commit 305e31c into GodotVR:master Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants