Update to Godot 4.3-stable #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Aug 15, 2024
dsnopek
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Looks good to me!
The tests appear to be failing due to some issue with Meta's NPM server? That's where we download the XR Simulator from and it's just stalling forever, even when I try the link locally:
https://npm.developer.oculus.com/com.meta.xr.simulator/-/com.meta.xr.simulator-65.0.0.tgz
Hopefully they'll fix it soon, but if not, we may need to release without that bit of the tests passing.
devloglogan
force-pushed
the
4.3-update
branch
from
66f73b9
to
f2bcbe2
Compare
|
I'm assuming we can ignore the XR simulator check for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
config.gradeandgodot-cppto Godot 4.3-stable!