-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the project structure #202
Conversation
71e0a65
to
c8c935a
Compare
Overall this looks good to me! I tested it locally, and everything seemed to work fine. However, I wonder if we should call the directory |
Sounds good to me. I went with
To:
We could also set the name to reflect its function (i.e: |
Yeah, that makes sense! And |
c8c935a
to
73af0da
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I tested rebuilding and running the composition layers sample on Quest 3, and everything seems to work.
- Consolidate all the vendors modules into a single `plugin` module with multiple vendors product flavors to allow for vendor-specific customizations - Add `GodotOpenXR.kt` to consolidate common java/kotlin logic for the OpenXR vendors plugin implementations - Move native code from the `common` directory to the `plugin/src/main/cpp` directory
73af0da
to
03e19c5
Compare
Refactor the project structure to reduce duplication of code, logic and build configs across the various vendors we support.
godotopenxr
module with multiple vendors product flavors to allow for vendor-specific customizationsGodotOpenXR.kt
to consolidate common java/kotlin logic for the OpenXR vendors plugin implementationscommon
directory to thegodotopenxr/src/main/cpp
directoryNote the changes in this PR are primarily due to file migration and updates of the logic and build configs as needed to match the new layout. No capabilities, functionality were added / removed / lost as part of the refactor.