Update switch statements to prevent build warnings #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the warnings are useful for that scenario; could we instead include all the enum, with a no-op comment for the ones where nothing needs to be done? |
devloglogan
force-pushed
the
build-warning-fix
branch
from
d2d541b
to
5e2ebd1
Compare
devloglogan
force-pushed
the
build-warning-fix
branch
from
5e2ebd1
to
d657477
Compare
It does complain bout |
m4gr3d
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks good to me!
I'll wait until @BastiaanOlij and @dsnopek chime in as well before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These switch statements throw a lot of warnings every time I build the plugin because not every enum value is explicitly handled. Changing them to if statements fixes that.