Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated github actions. #213

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Update deprecated github actions. #213

merged 1 commit into from
Oct 4, 2024

Conversation

Malcolmnixon
Copy link
Contributor

@Malcolmnixon Malcolmnixon commented Oct 1, 2024 •
edited
Loading

This PR fixes some issues with the CI build pipelines:

  1. Updates build actions to remove some of the deprecated warnings.
  2. Fixes archiving the addon by including hidden files such as the .bin folders
  3. Fixes godot build-cache restoring
  4. Adds godot build-cache saving
  5. Adds distributionSha256Sum to silence gradle warnings

The builds are much faster now and the build artifact is now packed and runs correctly.

The remaining deprecation issues are with the cache-script provided with godot-cpp so Godot will need to update it in the future.

@Malcolmnixon Malcolmnixon force-pushed the update-actions branch 5 times, most recently from bf23e87 to aaa6473 Compare October 2, 2024 00:15
BastiaanOlij
BastiaanOlij approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, all green flags on the CI so :)

dsnopek
dsnopek approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Thanks for catching the issue with the renamed godot-cpp actions

@BastiaanOlij BastiaanOlij merged commit 4ee0ff9 into GodotVR:master Oct 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@m4gr3d m4gr3d Awaiting requested review from m4gr3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Malcolmnixon @dsnopek @BastiaanOlij