New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: added fallback text option to youtube embed #83

Open

ShayPunter wants to merge 1 commit into main from 6193_youtube_embed_should_show_fallback_link

Collaborator

ShayPunter commented May 11, 2023

Fixes: #6193

Suggested changes:

Adds fallback text to lite-youtube

How to test:

Clone webdev-infra and checkout branch
Clone d.c.c repository and checkout branch 6193_youtube_embed_should_show_fallback_link_when_js_is_disabled
Setup a sym link between the webdev-infra and d.c.c repository
Navigate to /blog/new-in-chrome-113/ with javascript enabled, you should see the youtube video as expected
Disable javascript
Refresh the page, you should now see the fallback text in place of the youtube video


          feat: added fallback text if users dont have js enabled

d43d655

ShayPunter marked this pull request as ready for review

May 11, 2023 13:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet